Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 84.65% 84.61% -0.05%
==========================================
Files 447 447
Lines 39428 39455 +27
==========================================
+ Hits 33378 33385 +7
- Misses 6050 6070 +20
🚀 New features to boost your workflow:
|
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the clean command (v2) to the toolkit, allowing users to delete resources based on build configurations by extending the existing deployment logic. Feedback was provided regarding the suppression of skipped resource information during the result merging process, which may obscure important details like data-loss prevention warnings from the final summary.
| for result in results: | ||
| if other_result := other_by_name.get(result.resource_name): | ||
| # We do not include skipped from the clean results. | ||
| other_result.skipped.clear() |
There was a problem hiding this comment.
Clearing skipped items from the clean phase can hide important information from the user. For example, when using deploy --drop without --drop-data, data resources are not dropped but are instead skipped with a HAS-DATA reason. The current implementation clears this skipped information, and the final report only shows the resource as 'updated' or 'unchanged', which can be misleading as the user might incorrectly assume that the resource was dropped and recreated.
To provide more transparency, consider removing this line. This will ensure that skipped items from the clean phase are included in the final summary, giving the user a complete picture of the operation.
# Description Note this is stacked on two branches #2796 , and the branch #2792 -> #2797 . Adds a unit test that builds and deploy the complete orgs. Found a few bugs through the testing: 1. CDF Project not set in `lineage.yaml` when running `cdf build`. 2. Unwrapping build variables were not done correctly for iteration cases. 3. Lineage serialized as relative paths, but requires absolute paths causing failure when loading. 4. Graphql was found in an incorrect way. ## Bump - [ ] Patch - [x] Skip
2 participants
Description
Reusing the deploy v2 command for clean v2.
Bump